Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Composer require-dev During Build #90

Closed
jaswrks opened this issue Apr 23, 2016 · 2 comments
Closed

Improve Composer require-dev During Build #90

jaswrks opened this issue Apr 23, 2016 · 2 comments
Labels
bug

Comments

@jaswrks
Copy link
Contributor

jaswrks commented Apr 23, 2016 •
edited
Loading

During the build process (i.e., in the .~build/[dir] phase), we should run Composer a second time and with an additional flag that will be sure to exclude all require-dev dependencies, as these should never be included in any official build of the software for redistribution.

At the moment, we have some hard-coded exclusions to work around this issue already, but moving forward this is going to become a bigger problem. Particularly when it comes to the WPSC.

Referencing install option: --no-dev:
https://getcomposer.org/doc/03-cli.md#install
@jaswrks jaswrks added the bug label Apr 23, 2016
@jaswrks jaswrks mentioned this issue Apr 23, 2016
Closed
@raamdev raamdev mentioned this issue May 12, 2016
Closed
@raamdev
Copy link
Contributor

raamdev commented May 12, 2016

Related: #88

@jaswrks jaswrks mentioned this issue May 25, 2016
Merged
7 tasks
@jaswrks
Copy link
Contributor Author

jaswrks commented May 26, 2016

Resolved in the release of v160526.
https://github.com/websharks/phings/releases/tag/160526

@jaswrks jaswrks closed this as completed May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raamdev @jaswrks