Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with combining CSS from <head> and <body> into fewer files #446

Closed
skipthedrive opened this issue Mar 16, 2015 · 8 comments
Closed

Problem with combining CSS from <head> and <body> into fewer files #446

skipthedrive opened this issue Mar 16, 2015 · 8 comments
Labels
html compressor needs testing

Comments

@skipthedrive
Copy link

Hello -
My styling pretty much went away when I had this option enabled. I'm able to have all of the other HTML compression options enabled except for this one. If you want to take a look at my home page, it's http://www.skipthedrive.com. As of now, I'm keeping this option disabled.
Thanks,
Pete
@raamdev
Copy link
Contributor

raamdev commented Mar 17, 2015

@skipthedrive Thanks for the heads up, Pete!

@jaswsinc Any chance you might take a look at this?

@jaswrks jaswrks mentioned this issue Mar 17, 2015
Open
6 tasks
@jaswrks
Copy link

jaswrks commented Mar 17, 2015

Yes, will do. Thanks. I'm making a note of this here: wpsharks/html-compressor#53

@skipthedrive
Copy link
Author

No problem @raamdev ! I also noticed a PHP warning and exception, but am not sure if it's related to this issue or not. Here it is:

[16-Mar-2015 22:55:01 UTC] PHP Warning: file_put_contents(/.../wp-content/cache/zencache/htmlc/public/www-skipthedrive-com/f/3/0/a/c/b5f3acbd767fdca3e9fd606fa8d5c311-compressor-part.js.55075f45b576c4.83502659.tmp): failed to open stream: No such file or directory in /.../wp-content/plugins/zencache-pro/submodules/html-compressor/html-compressor/includes/core.php on line 1255
[16-Mar-2015 22:55:01 UTC] PHP Fatal error: Uncaught exception 'Exception' with message 'Unable to cache JS code file: /.../wp-content/cache/zencache/htmlc/public/www-skipthedrive-com/f/3/0/a/c/b5f3acbd767fdca3e9fd606fa8d5c311-compressor-part.js.' in /.../wp-content/plugins/zencache-pro/submodules/html-compressor/html-compressor/includes/core.php:1256
Stack trace:
#0 /.../wp-content/plugins/zencache-pro/submodules/html-compressor/html-compressor/includes/core.php(1063): websharks\html_compressor\core->compile_js_tag_frags_into_parts(Array)
#1 /.../wp-content/plugins/zencache-pro/submodules/html-compressor/html-compressor/includes/core.php(318): websharks\html_compressor\core->maybe_compress_combine_head_js('<!doctype html>...')
#2 /.../wp-content/advanced-cache.php(1406): websharks\html_compressor\core->compress('<!doctype html>...')
#3 /.../wp-content/advanced-cache.php(1320): zencache\advanced_c in /.../wp-content/plugins/zencache-pro/submodules/html-compressor/html-compressor/includes/core.php on line 1256

@jaswrks
Copy link

jaswrks commented Mar 18, 2015

@skipthedrive writes...

I also noticed a PHP warning and exception, but am not sure if it's related to this issue or not.

Thank you very much for those additional details :-)

@skipthedrive
Copy link
Author

Sure thing!

@renzms
Copy link

renzms commented Dec 29, 2016

@raamdev

Unable to reproduce issue

WordPress Version: 4.7
Current WordPress Theme: Illdy version 1.0.35.2
Theme Author: Colorlib - http://colorlib.com
Theme URI: http://colorlib.com/wp/themes/illdy/
Active Plugins: Comet Cache Pro v161227
PHP Version: 7.0.10-2+deb.sury.org~xenial+1
MySQL Version: 10.0.28-MariaDB-0ubuntu0.16.04.1

HTML Compressor enabled

screen shot 2016-12-30 at 12 01 02 am

Front end with Theme + Stylings

screen 12-29_23-45-21

@skipthedrive
Copy link
Author

Yep, seems to be working fine now. Thanks!

@raamdev
Copy link
Contributor

raamdev commented Dec 29, 2016

@renzms @skipthedrive Thanks for the confirmation! :-) I'll go ahead and close this.

@raamdev raamdev closed this as completed Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
html compressor needs testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@raamdev @jaswrks @skipthedrive @renzms