Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added WPP.chat.sendScheduledCallMessage (close #1381) #1389

Merged
merged 5 commits into from
Sep 27, 2023
Merged

feat: Added WPP.chat.sendScheduledCallMessage (close #1381) #1389

merged 5 commits into from
Sep 27, 2023

Conversation

icleitoncosta
Copy link
Contributor

No description provided.

edgardmessias
edgardmessias requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@edgardmessias edgardmessias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adicionei pequenas sugestões para evitar possíveis problemas no futuro.

src/chat/functions/sendScheduledCallMessage.ts Outdated Show resolved Hide resolved
src/chat/functions/sendScheduledCallMessage.ts Outdated Show resolved Hide resolved
src/chat/functions/sendScheduledCallMessage.ts Outdated Show resolved Hide resolved
src/chat/functions/sendScheduledCallMessage.ts Show resolved Hide resolved
@icleitoncosta
Copy link
Contributor Author

Adicionei pequenas sugestões para evitar possíveis problemas no futuro.

Perfeito, muito bem pensado

icleitoncosta and others added 4 commits September 27, 2023 13:13
@icleitoncosta @edgardmessias
fix: Fixed type
5981317 
Co-authored-by: Edgard Lorraine Messias <[email protected]>
@icleitoncosta @edgardmessias
fix: Fixed onFullReady function
4111d6a 
Co-authored-by: Edgard Lorraine Messias <[email protected]>
@icleitoncosta @edgardmessias
fix: Added default value
3b84dfa 
Co-authored-by: Edgard Lorraine Messias <[email protected]>
@icleitoncosta
fix: Fixed reviews
df6c523
@icleitoncosta
Copy link
Contributor Author

Opa @edgardmessias, fiz os ajustes solicitados.

edgardmessias
edgardmessias approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@edgardmessias edgardmessias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprovado, na hora de fazer merge, usar o squash para ficar apenas um commit

@icleitoncosta icleitoncosta merged commit d706459 into wppconnect-team:main Sep 27, 2023
@icleitoncosta icleitoncosta deleted the schedulle-call branch September 27, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgardmessias edgardmessias edgardmessias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icleitoncosta @edgardmessias