Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Deprecated: round(): Passing null to parameter #1 ($num) of type int|float is deprecated when click what plan do I need #909

Open
Mai-Saad opened this issue Oct 16, 2024 · 1 comment
Labels
priority: medium Issues which are important, but no one will go out of business. severity: minor type: bug

Comments

@Mai-Saad
Copy link

Mai-Saad commented Oct 16, 2024

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version => 2.2.2
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
When click what plan do I need on imagify green banner 2.2.2 or upgrade link in admin bar at 2.2.3 we have deprecated notice in debug.log

To Reproduce
Steps to reproduce the behavior:

  1. Fresh install/activate of 2.2.2 for starter account with balance >20%
  2. Click on What plan do I need in green banner
  3. check debug.log
[16-Oct-2024 13:17:11 UTC] PHP Deprecated:  round(): Passing null to parameter #1 ($num) of type int|float is deprecated in /var/www/new.rocketlabsqa.ovh/htdocs/wp-content/plugins/imagify/inc/classes/class-imagify-files-stats.php on line 408
[16-Oct-2024 13:17:11 UTC] PHP Deprecated:  round(): Passing null to parameter #1 ($num) of type int|float is deprecated in /var/www/new.rocketlabsqa.ovh/htdocs/wp-content/plugins/imagify/inc/classes/class-imagify-files-stats.php on line 438

Expected behavior
No deprecated notice

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

  • same will occur on 2.2.3 if we click the upgrade link in admin bar or green banner
    Acceptance Criteria (for WP Media team use only)
    Clear instructions for developers, to be added before the grooming
@Khadreal
Copy link
Contributor

I fixed this in this PR, check this commit 079a2f4. We can close this ticket.
cc @Mai-Saad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Issues which are important, but no one will go out of business. severity: minor type: bug
Projects
None yet
Development

No branches or pull requests

2 participants