-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make-pot pointing to raw JSX file, not built JS file #212
Comments
Thanks, @ocean90. I tried If that's not what debug's output is telling me, then the exclude isn't working, I guess being overridden by include, which seems odd. If that's the case, it's not quite the same as #185, since I don't have a wildcard include, only a wildcard exclude. Thoughts? |
Unfortunately, include is broken too, see #186. |
Interesting. TYVM for the help. Any idea how bugs in this CLI command affect ability to translate on .org, such as if my plugin has JSX that builds to JS and does not ship JSX files to .org, and I don't generate a .pot for .org, then things should still be translatable by .org's team because all they'd know about is the built JS files, right? |
Correct, the built files are what really matters. For testing you can use On w.org we're still using 2.2.0 fwiw. |
gracias! |
wp i18n make-pot . languages/rankbear.pot --include='dist,src' --exclude='*.jsx,*.map,*.svg,*.txt' --color'
Example built file (currently private project but will be public) in my dist directory:
Why does the .pot file point to the JSX file instead of the built JS file?
The text was updated successfully, but these errors were encountered: