Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translator comments are not extracted when PHP comment starts with a tab character #169

Closed
ocean90 opened this issue Jul 12, 2019 · 0 comments · Fixed by #170
Closed

Translator comments are not extracted when PHP comment starts with a tab character #169

ocean90 opened this issue Jul 12, 2019 · 0 comments · Fixed by #170

Comments

@ocean90
Copy link
Contributor

ocean90 commented Jul 12, 2019

Reported in https://core.trac.wordpress.org/ticket/47691.

The following snippet is using tabs for indentation and the comment doesn't get extracted.

	/*
	 * translators: Use this to specify the proper Google Font name and variants
	 * to load that is supported by your language. Do not translate.
	 * Set to 'off' to disable loading.
	 */
	_x( 'Noto Serif:400,400i,700,700i', 'Google Font Name and Variants' );

But when using spaces it works.

    /*
     * translators: Use this to specify the proper Google Font name and variants
     * to load that is supported by your language. Do not translate.
     * Set to 'off' to disable loading.
     */
    _x( 'Noto Serif:400,400i,700,700i', 'Google Font Name and Variants' );

This probably needs to be reported upstream but I'd like to have at least a test for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants