Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ethers" is being included as a devDependency #565

Open
cosullivan opened this issue Nov 17, 2021 · 3 comments
Open

"ethers" is being included as a devDependency #565

cosullivan opened this issue Nov 17, 2021 · 3 comments
Assignees

Comments

@cosullivan
Copy link

Hi,

With the SDK, the ethers package is being included as a devDependency which means that it has to be installed separately when using the package.

This should be a dependency instead.

Thanks, Cain.

@ali-bahjati
Copy link
Contributor

I got the same problem too.

Error: Cannot find module 'ethers/lib/utils'
Require stack:
- /Users/abehjati/src/pyth/pyth-crosschain/ethereum/node_modules/@certusone/wormhole-sdk/lib/cjs/utils/aptos.js
- /Users/abehjati/src/pyth/pyth-crosschain/ethereum/node_modules/@certusone/wormhole-sdk/lib/cjs/utils/index.js
- /Users/abehjati/src/pyth/pyth-crosschain/ethereum/node_modules/@certusone/wormhole-sdk/lib/cjs/rpc/getSignedVAAWithRetry.js
- /Users/abehjati/src/pyth/pyth-crosschain/ethereum/node_modules/@certusone/wormhole-sdk/lib/cjs/rpc/index.js
- /Users/abehjati/src/pyth/pyth-crosschain/ethereum/node_modules/@certusone/wormhole-sdk/lib/cjs/index.js

@evan-gray
Copy link
Contributor

Likely, the entire SDK should be switched to using peer-dependencies for these sorts of things.

@ali-bahjati
Copy link
Contributor

Well.. if the types are used in the package type definitions then maybe it should be marked as dependency, shouldn't it? Or then again everyone needs to skip lib type check.

@aadam-10 aadam-10 added this to the Maintenance - SDK milestone Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants