Add compatibility with ModelingToolkit 9 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natema
requested review from
aurorarossi
and removed request for
natema and
paulobruno
|
OK, ModelingToolkit requires julia >= 1.9 but the Symbolics package requires julia >=1.10. I am going to change that again. |
|
Hi @aurorarossi, please let me know if there's anything else I need to do for this PR to be merged. |
aurorarossi
approved these changes
Apr 18, 2024
|
I talked to the other member of the organization and yes, the PR can be merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR adds compatibility with the latest major release of ModelingToolkit (v9).
Since test coverage is not very high, please make sure nothing broke with my changes.
Also, before merging, similar changes need to be made to the Earth4all repo (see worlddynamics/Earth4All.jl/pull/16), as it depends on this one.
Closes #208
Best