Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow gRPC QuerySummarySync, QueryNotificationSync and QueryResultSync to return ServiceException #166

Open
hanstrompert opened this issue Dec 19, 2024 · 0 comments
Assignees

Comments

@hanstrompert
Copy link
Member

At the moment, the gRPC QuerySummarySync, QueryNotificationSync and QueryResultSync, when processing fails, will raise a python NsiException which results in an GENERIC_INTERNAL_ERROR in PolyNSI. The last mentioned error does contain the information from the NSIException, but it is a bit crude, and breaks the NSI specification.

The proper way to implement this is to add a common.ServiceException service_exception field to the QueryConfirmedRequest, QueryNotificationConfirmedRequest and QueryResultConfirmedRequest, which are shared by the synchronous and asynchronous version of the different query requests, and have PolyNSI check for the existence of this field in the Protobuf message, and throw a ServiceException that will send the appropriate SOAP fault to the requester.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant