Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting inline text into a link splits the link apart #839

Closed
mkevins opened this issue Apr 8, 2019 · 1 comment
Closed

Pasting inline text into a link splits the link apart #839

mkevins opened this issue Apr 8, 2019 · 1 comment
Labels

Comments

@mkevins
Copy link
Contributor

mkevins commented Apr 8, 2019

Describe the bug

When pasting text in the middle of a link, the link is split (pasted text is not part of the link).

This makes it impossible to quickly change the link text via copy/paste.

Steps to reproduce

  1. Select some text and create a link.
  2. Copy some small inline text.
  3. Place cursor within the link and paste.

Expected behavior:

Pasted text becomes part of the link.

Actual behavior:

Pasted text is not part of the link, and the link is split in two pieces.

Screenshot:

Note:

This issue was found in Gutenberg (WordPress/gutenberg#11571) and already has a fix there: WordPress/gutenberg#14815 . It may be possible to port some / all of the code changes in this PR to packages/block-editor/src/components/rich-text/index.native.js to fix the same issue on mobile.

@cameronvoell
Copy link
Contributor

Fixed via WordPress/gutenberg#14815 and WordPress/gutenberg#19190. (See the video in WordPress/gutenberg#19190)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants