Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-block indicator and newly added block is in the wrong position after selecting the Title #3636

Closed
hypest opened this issue Jun 18, 2021 · 2 comments · Fixed by #3640
Closed
Assignees
Labels
[Pri] High [Type] Bug Something isn't working

Comments

@hypest
Copy link
Contributor

hypest commented Jun 18, 2021

After selecting the Title and then some other block, and then try to add a new block from the block picker, the blue line/indicator is at the wrong place.

To Reproduce
Steps to reproduce the behavior:

  1. In the demo app
  2. Tap on the Title
  3. Then tap on a block a couple of blocks away
  4. Then tap on the "+" toolbar button to add a new block from the picker
  5. 💥 Notice that the new-block indicator is right below the title instead of being below the currently selected block. See video below too.
  6. Select a new block from the picker and notice that it's added at the wrong place
indicator_wrong.mp4

Expected behavior
The new-block indicator should be below the selected block, not the Title.

Smartphone (please complete the following information):

  • Device: Pixel 2XL
  • OS: Android 11
  • Version on develop hash 11c7f70
  • Verified happening on WPAndroid 17.5 (production at the time of writing)
@hypest hypest added [Type] Bug Something isn't working [Pri] High labels Jun 18, 2021
@hypest hypest changed the title New-block indicator is in the wrong position after selecting the Title New-block indicator and newly added block is in the wrong position after selecting the Title Jun 18, 2021
@hypest
Copy link
Contributor Author

hypest commented Jun 18, 2021

From my debugging so far, looks like the the editor settings memo doesn't get triggered when the Title get unselected.

@fluiddot
Copy link
Contributor

Looks like we have the same issue opened in Gutenberg:
WordPress/gutenberg#32154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] High [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants