Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The editor Crashes when adding a Caption to a Gallery block #3510

Closed
antonis opened this issue May 17, 2021 · 3 comments · Fixed by #3534
Closed

The editor Crashes when adding a Caption to a Gallery block #3510

antonis opened this issue May 17, 2021 · 3 comments · Fixed by #3534

Comments

@antonis
Copy link

antonis commented May 17, 2021

Describe the bug
The editor Crashes when adding a Caption to a Gallery block

To Reproduce
Follow the steps on TC003 or:

  1. Add a Gallery block
  2. Add some images from the device or media library
  3. Tap on the gallery caption
  4. Notice the the editor crashes

The Crash occurs both on Android and iOS

Expected behavior
The user is able to add a gallery caption.

Screenshots

device-2021-05-17-144841.mp4

Smartphone (please complete the following information):

  • Device: Pixel 2 XL, iPhone SE
  • OS: Android 11.0, iOS 14.4
  • Version Gutenberg Mobile 1.53.0
@mkevins
Copy link
Contributor

mkevins commented May 18, 2021

I have reproduced this issue, and debugging it points to the removal of the onFocusGalleryCaption in this commit: WordPress/gutenberg@9a6e3fc, in this PR: WordPress/gutenberg#31796. I have confirmed that after reverting those changes, I can no longer reproduce the crash.

@fluiddot
Copy link
Contributor

fluiddot commented Jun 1, 2021

This issue can be also reproduced in version 17.3.2.

Sentry issue ID: 1509710590

@AmandaRiu
Copy link
Contributor

NOTE: This crash was fixed in this PR and included in the gutenberg-mobile 1.53.1 release which is bundled in the 17.4 release of the WordPress apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment