Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help behavior to the SwitchCell component #3169

Closed
jd-alexander opened this issue Feb 17, 2021 · 4 comments · Fixed by #3380
Closed

Add help behavior to the SwitchCell component #3169

jd-alexander opened this issue Feb 17, 2021 · 4 comments · Fixed by #3380
Labels
[Pri] Low [Type] Enhancement Improves a current area of the editor

Comments

@jd-alexander
Copy link
Contributor

jd-alexander commented Feb 17, 2021

Description

The help behavior should be added to the SwitchCell component. The use case for this at the moment is with the Video & Audio Block that requires the user to be informed about the usability implications that will be experienced by users if the autoplay attribute is enabled on the block in question.

Screenshots

Web

autoplay

Mobile

Image from iOS

The proposed option is # 1 based on design specs below by @iamthomasbishop

  • In-cell subtitles are meant for short labels.
  • Footnotes can get quite long as well, so it's best to utilize them without a divider.
@jd-alexander jd-alexander added the [Type] Enhancement Improves a current area of the editor label Feb 17, 2021
@mchowning
Copy link
Contributor

mchowning commented Feb 18, 2021

👋 @jd-alexander ! I think you're more familiar with this feature request than I am. Would you mind selecting a priority label that you think is appropriate for this?

@jd-alexander
Copy link
Contributor Author

👋 @jd-alexander ! I think you're more familiar with this feature request than I am. Would you mind selecting a priority label that you think is appropriate for this?

Sure @mchowning I will do that. Should I put a priority label on all issues I create?

@mchowning
Copy link
Contributor

mchowning commented Feb 19, 2021

Thanks @jd-alexander ! 🙇

Should I put a priority label on all issues I create?

If you have a sense for what the priority should be, that would definitely be helpful since you'll probably have the most context around the issue. If you don't add a priority, then whoever triages new issues will assign a priority.

@jd-alexander
Copy link
Contributor Author

Thanks @jd-alexander ! 🙇

Should I put a priority label on all issues I create?

If you have a sense for what the priority should be, that would definitely be helpful since you'll probably have the most context around the issue. If you don't add a priority, then whoever does triages new issues will assign a priority.

Understood. Thanks for clearing that up 🙏🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Low [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants