Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redoing insertion of an image loses subsequent redo history #2499

Open
mchowning opened this issue Jul 21, 2020 · 3 comments
Open

Redoing insertion of an image loses subsequent redo history #2499

mchowning opened this issue Jul 21, 2020 · 3 comments
Labels

Comments

@mchowning
Copy link
Contributor

Describe the bug
When using redo to restore an image in an image block, the subsequent redo history is lost. In other words, any of the changes done after the image was inserted cannot be restored.

To Reproduce
Steps to reproduce the behavior:

  1. Insert an image block
  2. Add an image to the image block
  3. Add some text to the post (could be in the caption or in a new block)
  4. Tap undo until the image block is empty (i.e., it has the "ADD IMAGE" text)
  5. Tap redo to restore the image to the image block
  6. Observe that the redo button is now disabled and you cannot restore any of the changes you made after adding the image

Expected behavior
It should be possible to restore changes made after restoring the image inserted into an image block.

Screenshots
redo_image mp4

Smartphone (please complete the following information):

  • Device: Pixel 1, iPhone Xr
  • OS: e.g. iOS 13.5.1, Android X
  • Version: WPAndroid 15.2.1, WPiOS Internal 15.3.0.202007137417bf8

Additional context
Although there is probably a different underlying cause, there is an iOS specific issue whereby links that open new tabs also lose undo history: #2091

@mchowning mchowning mentioned this issue Jul 21, 2020
6 tasks
@guarani
Copy link
Contributor

guarani commented Jul 29, 2020

I tried reproducing and this is what I found:

@AmandaRiu
Copy link
Contributor

FYI: Still an issue as of 1.57.0. Tested on a physical Pixel 4 running Android 11 w/ Gboard:

screencapture-1626125609561.mp4

@guarani
Copy link
Contributor

guarani commented Sep 17, 2021

I'm no longer seeing this issue on WPiOS 18.1 (18.1.0.4). I am still seeing the issue occasionally on WPAndroid 18.2-rc-3 (2 out of 4 attempts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants