-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for wide/full-width Alignment options #2463
Comments
Let's start with Cover > Group > Columns as they are the ones commonly used in layouts with full/wide width. |
Design update: I spent some time last week and earlier this week tinkering with wide/full-width alignments on the web and some other applications. I have a bunch of notes jotted down, but as a summary, I'll share the high-level overview, some digital sketches, static designs, and a Codepen playground I created to get a feel for these alignments on different screen sizes. My notes are mostly focused on the "wide" alignment, because its logic is a bit more complex than the full width alignment. Note: @geriux I know you're already well on your way to implementing this, but let me know if there's anything that stands out or doesn't align with your work thus far. 😄 Current StateContent-width
Canvas left/right spacing
Wide container
Full width container
Proposal
Static DesignsBased on the above logic, here's some mockups of the "wide" alignment would look like on different device sizes: CodepenAs mentioned, I put together a little Codepen in order to get a better feel for how the spacing would look on various device sizes. By no means is this intended to be perfect (or even final), but rather a reference during exploration. View on Codepen cc @pinarol |
Thank you for the detailed explanation of the different cases @iamthomasbishop! So far everything looks good, I don't see any issues as of yet but If some come up I'll let you know. |
I'm reopening this issue to track adding support for the rest of the blocks. Group, Cover, and Image are done and merged in develop. ✅ |
Closing since the rest of the blocks have support now, WordPress/gutenberg#25184 and WordPress/gutenberg#25621 |
Let's start to think about how we can bring wide/full-width Alignment options into mobile. They are very useful in pages and starter page layouts(mostly homepage layouts).
For this issue I am thinking about only focusing on wide/full-width, but not on 'left, right, center'.
Current blocks that support wide/full-width:
Describe the solution you'd like
Technically I would like to focus on a solution that can work based on the support flags "align", "alignWide" to keep parity with web. If
align:true
is present in the support flags we should display the alignment options in the toolbar. There's one exception, if we havealignWide:false
then we shouldn't be displaying wide/full-width options.I'll leave the UX side for @iamthomasbishop.
The text was updated successfully, but these errors were encountered: