-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gallery block: allow editing image #2389
Comments
Hey @iamthomasbishop 👋 I'm working on adding media editing for Gallery but I'd need some design specifications for the UI of the buttons. We need to find a place for the Media editing button, the thing is it shouldn't be too different from Image, Media & Text, and Cover so we reuse as much as we can since all of them share the same Image component. I'm attaching a screenshot of the new button in Gallery, I had to move the remove button so I could show you better. Let me know any ideas/questions you might have. Functionality wise, the new button will open the options Edit and Replace. Tapping on the image would open the image in full screen.
Thank you! |
@geriux perhaps we should put the 'x' action in the edit menu to conserve some space? Question: would a long-press on a gallery image cell open the action sheet like we have on image and now cover blocks? |
I moved the delete action, what do you think?
Yup, I show it in the gif above as well =) Thanks! |
@geriux I like that! One tiny nitpick: Can we change "delete" to "remove"? Because we are just removing image from the gallery, not deleting it altogether. 😊 |
Let's focus on bringing image editing into Gallery after completing the work with Media-Text.
The text was updated successfully, but these errors were encountered: