Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media-Text: Add support for rendering focal point config #2253

Closed
pinarol opened this issue May 12, 2020 · 2 comments
Closed

Media-Text: Add support for rendering focal point config #2253

pinarol opened this issue May 12, 2020 · 2 comments
Assignees
Labels
[Type] Enhancement Improves a current area of the editor

Comments

@pinarol
Copy link
Contributor

pinarol commented May 12, 2020

Recently Media-Text on web started to support Focal point configuration. We don't have a support for that setting yet but we can start with properly rendering the image. Plus, I think we can add the Crop image to fill entire column setting as well.

Screen Shot 2020-05-12 at 20 57 50

@pinarol pinarol added the [Type] Enhancement Improves a current area of the editor label May 12, 2020
@pinarol
Copy link
Contributor Author

pinarol commented May 12, 2020

Also I want to ask @iamthomasbishop, we can support focal point settings just by adding 2 Sliders, 1 for horizontal and the other for vertical position, wdyt?

@iamthomasbishop
Copy link
Contributor

@pinarol We certainly could, provided that the image focal point is updated in relative realtime on the block itself so that the results are visible. Although I would definitely prefer to have a more visual dragging UI over the top of the image, similar to what @lukewalczak built for the custom color picker — this would work as a v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants