Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote Block display does not respect alignment #2161

Closed
mchowning opened this issue Apr 16, 2020 · 2 comments
Closed

Quote Block display does not respect alignment #2161

mchowning opened this issue Apr 16, 2020 · 2 comments
Labels
Project: Flow improvements Revise/enhance various editing flows

Comments

@mchowning
Copy link
Contributor

Describe the bug
Changing the alignment within a quote block does not change the text visually, although the alignment attribute does get updated.

To Reproduce
Steps to reproduce the behavior:

  1. Create a quote block
  2. Change the alignment
  3. Observe that the quote block does not visually reflect the alignment

Expected behavior
The quote block should visually reflect alignment

Smartphone (please complete the following information):

Additional context
Comment where @etoledom initially identified the issue

@mchowning
Copy link
Contributor Author

mchowning commented Apr 16, 2020

In order to address this on iOS we just need to pass the align prop to the RichText component as the textAlign prop. It's not currently being passed at all.

We also need the changes from this AztecEditor-Android PR in order for alignment to start working on Android.

@mchowning
Copy link
Contributor Author

This was addressed in #2006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project: Flow improvements Revise/enhance various editing flows
Projects
None yet
Development

No branches or pull requests

2 participants