-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quote block placeholder is not visible #1970
Comments
Going to save a few notes on here (perhaps for myself). We are seeing the missing placeholder because multiline prop/functionality causes empty paragraph tags ( If we simply catch when we have an empty paragraph tag, and set the text to an empty string ( Unfortunately, even after a few small victories, I was still seeing some broken behaviors when merging blocks or doing multiline quotes with my strategy of deleting paragraph tags on empty blocks, and fixing the code reliant on them. An alternate strategy is to go to the |
I was able to get this working with a relatively safe looking change. The fix itself appears a bit unintuitive, and could probably use a larger refactor, but the more minimal change here in the following PR's seemed like the least intrusive way to fix this in the near term: |
Describe the bug
Quote block's
Write Quote...
placeholder is not visible on AndroidTo Reproduce
Quote
blockWrite Quote...
placeholder on top ofWrite Citation...
placeholder doesn't appear on AndroidExpected behavior
There should be a
Write Quote...
placeholder on top ofWrite Citation...
placeholderScreenshots
Smartphone (please complete the following information):
Additional context
Realised this while implementing
Pullquote
block: #1920WordPress/gutenberg#20265
Quote block uses
RichText
to implement the text inputs and issue seems to be with that component. For theQuote
block the only difference between the quote and citation input fields is that the quote input gets themultiline
prop passed in: https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/quote/edit.js#L45When
multiline
prop is removed it works as expected.The text was updated successfully, but these errors were encountered: