YellowBox Warning: componentWillReceiveProps is deprecated

[maxme]

There is currently a warning showing on the gutenberg mobile demo app:

Warning: componentWillReceiveProps is deprecated and will be removed in the next major version. Use static getDerivedStateFromProps instead.

It's due to at least one of our dependencies:

I couldn't find any occurrences of componentWillReceiveProps in our code, so I think updating the dependencies would be enough to fix this.

[maxme]

I tried to upgrade react-native-modal to latest version (v11.1.0). Doing this removes the warning, but there is another warning when the bottom sheet animation starts:

This one comes from a react-native-modal dependency: react-native-animatable and is not fixed yet:

oblador/react-native-animatable#180 (comment)

[maxme]

In the meantime, one can hide this warning by adding it to the ignore list in src/index.js:

diff --git a/src/index.js b/src/index.js
index b0554c0f..684d0bc3 100644
--- a/src/index.js
+++ b/src/index.js
@@ -77,7 +77,7 @@ export class RootComponent extends React.Component {

 export function registerApp() {
        // Disable require circle warnings showing up in the app (they will still be visible in the console)
-       YellowBox.ignoreWarnings( [ 'Require cycle:' ] );
+       YellowBox.ignoreWarnings( [ 'Require cycle:', 'componentWillReceiveProps'] );

[hypest]

Not seeing the YellowBox anymore, at least on 7495fbf. Closing but let's reopen if it comes back.

[mchowning]

I just commented out this line:

console.disableYellowBox = true;

and loaded the editor to this 😱

I'm thinking maybe we should keep this one open 🙂 (there are some componentWillReceiveProps deprecation warnings in there), and probably add new issues for the other warnings too. WDYT @hypest ?

If we ignore the "Require cycle" warnings specifically, it looks like the number of remaining YellowBox warnings would be much more manageable, although I think there will still be enough that it will be very annoying to deal with.

[hypest]

Yes, let's re-open.

Also, wondering if the 0.62.x upgrade has the same issues reported.

[geriux]

Closing since there are no componentWillReceiveProps references anymore.