Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichText/AztecWrapper crashes with "set span (x+1..x+1) ends beyond length x" #1131

Closed
daniloercoli opened this issue Jun 13, 2019 · 5 comments

Comments

@daniloercoli
Copy link
Contributor

I was able to reproduce the (in)famous set span (xx..XX) ends beyond... red screen error on Android, on both version 1.6.1, and 1.7.0 of gb-mobile.

There were some reports of this crash in Sentry, but we weren't aware fo steps to reproduce it.

I guess it's a mix of auto-corrector settings, and the Gboard keyabord, that can result into this problem. Cannot reproduce on AOSP keyboard.

device-2019-06-13-155214

v1.7 https://cloudup.com/c0tiPnG6sYn

  • Start writing into a para block
  • Make a typo on the last word
  • Tap Enter, it does correct the word, and create a new line in the RichText field
  • Tap enter again to create a new block
  • New block is created, and the "extra" new line is then removed by our cleaning utils in the previous block
  • Tap Backspace
  • Boom

v1.6.1

  • Start writing into a para block
  • Make a typo on the last word
  • Tap Enter, it does correct the word, and create a new line in the RichText field
  • Tap Backspace (it does remove the autocorrection)
  • Tap enter again to create a new block
  • New block is created, and the "extra" new line is then removed by our cleaning utils in the previous block
  • Tap Backspace
  • Boom

Tested on Android 7.1, GBoard, on Nexus 5x

@marecar3
Copy link
Contributor

Hey @daniloercoli I have tried to reproduce this one on Nexus 5x 8.1 but when I click on the enter, it creates a new block (not a new line). Is this specific to 7.1 Android?

@hypest
Copy link
Contributor

hypest commented Jul 9, 2019

👋 @marecar3 , reassigned this ticket to you since Danilo is going to divert effort to the "opt-in API" ticket instead.

@marecar3
Copy link
Contributor

marecar3 commented Jul 9, 2019

Thanks for the update! @hypest

@marecar3 marecar3 removed their assignment Aug 6, 2019
@Tug
Copy link
Contributor

Tug commented Sep 23, 2019

Related to #872

@daniloercoli
Copy link
Contributor Author

Closing this issue here, since testing steps provided are no longer replicating it.
We've already 2 other issues about the same crash in Aztec, and in GB-mobile (powered by Aztec), and will move those in GB-mobile v2 project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants