We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The editor crashes when merging blocks after splitting. This is very similar and may be a partial regression of #921, which was fixed by #949.
This seems to be fixed by #1032, however, it is difficult to follow why this is the case.
In the diff, isSelected can be set from true to false (but not false to true) based on the conditions here: https://github.com/WordPress/gutenberg/pull/15833/files#diff-4828a21853e899e5a36faecfa96d83e8L926. I suspect setting isSelected to false alters the control flow in other areas of the code, resulting in an invalid state, but I have not invested enough time to explore that.
isSelected
true
false
The blocks should merge into one.
The editor crashes 💥
The text was updated successfully, but these errors were encountered:
Closing this, as it has been resolved by #1032.
Sorry, something went wrong.
No branches or pull requests
Description
The editor crashes when merging blocks after splitting. This is very similar and may be a partial regression of #921, which was fixed by #949.
This seems to be fixed by #1032, however, it is difficult to follow why this is the case.
In the diff,
isSelected
can be set fromtrue
tofalse
(but notfalse
totrue
) based on the conditions here: https://github.com/WordPress/gutenberg/pull/15833/files#diff-4828a21853e899e5a36faecfa96d83e8L926. I suspect settingisSelected
to false alters the control flow in other areas of the code, resulting in an invalid state, but I have not invested enough time to explore that.Steps to reproduce
Expected
The blocks should merge into one.
Actual
The editor crashes 💥
Screenshot
The text was updated successfully, but these errors were encountered: