Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate gutenberg-mobile release 1.105.0 #21652

Merged
merged 6 commits into from
Sep 28, 2023

Conversation

derekblank
Copy link
Contributor

@derekblank derekblank commented Sep 28, 2023

Description

This PR incorporates the 1.105.0 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#6243

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@derekblank derekblank added the Gutenberg Editing and display of Gutenberg blocks. label Sep 28, 2023
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 28, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21652-bfd2098
Version23.3
Bundle IDorg.wordpress.alpha
Commitbfd2098
App Center BuildWPiOS - One-Offs #7224
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 28, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21652-bfd2098
Version23.3
Bundle IDcom.jetpack.alpha
Commitbfd2098
App Center Buildjetpack-installable-builds #6266
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@derekblank derekblank marked this pull request as ready for review September 28, 2023 04:54
@derekblank derekblank added this to the 23.4 milestone Sep 28, 2023
Comment on lines 1 to 3
23.5
-----

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to define the next version, AFAIK this change is made as part of the release process of the app.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 946e73f.

Podfile.lock Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why so many Pods have been updated after bumping the Gutenberg Mobile reference. I'm going to try reverting the change and running the Pod installation again to confirm whether the updates are expected.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted 306cbb8 and running bundle exec pod install didn't produce the changes referenced here. Hence, I'm going to commit the revert.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 7e3b42b.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

NOTE: Before merging the PR, we need to update the GBM reference to point to the release tag.

@fluiddot fluiddot merged commit 58ff9b2 into trunk Sep 28, 2023
@fluiddot fluiddot deleted the gutenberg/integrate_release_1.105.0 branch September 28, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants