Login: Invalid verification code error using 1Password when 2fa is enabled

[aerych]

@diegoreymendez caught an interesting glitch where the login would fail with a Invalid verification code error when attempting to login with a username via 1Password when 2fa is enabled on the account. For more context see our slack chat: p1541162895171200-slack-ios-osx-dev

Login succeeds under the same circumstances with an account without 2fa enabled.

Speculation: We're probably calling the wrong login method (or passing the wrong info in loginfields) so that its trying to satisfy a 2fa challenge before it should.

[aerych]

Hacked on this a bit. Code wise everything looks correct to my eyes. I've re-tested with a test account, and my work account and I can log in with 2fa and 1password using a username just fine with both app store build and the current beta. @rachelmcr was also successfully able to login when she looked.
@diegoreymendez I'm not sure how to account for the behavior you were seeing. Maybe we can take a closer look later?

[diegoreymendez]

@aerych - I can try debugging, will report back.

[rachelmcr]

It's possible this is not exactly a bug, but rather the timing issue described in #4636:

It's probably worth trying to catch your one-time password when it's about to expire. You can tap the 'i' in the 1Password extension to view the countdown for the code. The user should see the invalid verification code error screen, and can tap to head back to login.

[diegoreymendez]

I can still reproduce 100% of the time with my account on a fresh WP install from the App store. Let me know if there's anything I can do to help you narrow this down.

I'll send you a video privately since the 1P login screen shows more info than I'd like to include in a public GitHub issue.

[diegoreymendez]

Fyi, I was able to narrow down the issue I was having. It's mostly my fault it turns out, but there's some space to improve the experience.

It's an edge case though, so it may not be a priority issue.

It seems having a second 2FA code in my 1Password WordPress.com entry was the issue. The process was picking up the wrong 2FA code, which makes sense.

That said, while the error message given by the app is quite correct, it does seem to leave the app in a weird state where pressing next should let me insert the 2FA code manually (instead of trying again)... but again that may not be worth the effort right now since most users won't have two 2FA codes in 1P for their WordPress accounts.

[aerych]

Ah! That makes sense.
Yeah I agree that its probably low priority but the fix might be as simple as clearing the stored 2fa code on a failed attempt. I'll take a peek.

[aerych]

Removed myself from this one (for now) so its free for another to pick up.