Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide if we want to use UiString. #31

Closed
wzieba opened this issue Jul 20, 2021 · 0 comments · Fixed by #47
Closed

Decide if we want to use UiString. #31

wzieba opened this issue Jul 20, 2021 · 0 comments · Fixed by #47

Comments

@wzieba
Copy link
Contributor

wzieba commented Jul 20, 2021

Quoting code comment:

[UiString] is a utility sealed class that represents a string to be used in the UI. It allows a string to be represented as both string resource and text.

While this might be a good idea to a big codebase like WPAndroid, it might be not necessary overhead for this library. We should consider removing this class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce domain module wordpress-mobile/WordPress-MediaPicker-Android
1 participant
@wzieba