Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Aztec version to v1.5.1 #15618

Merged
merged 3 commits into from
Nov 25, 2021
Merged

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Nov 25, 2021

This PR bumps the Aztec version to v1.5.1 to include the fix wordpress-mobile/AztecEditor-Android#945 for the Gutenberg editor.

To test:
Follow testing instructions from wordpress-mobile/gutenberg-mobile#4290.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the Aztec label Nov 25, 2021
@fluiddot fluiddot self-assigned this Nov 25, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 25, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@fluiddot fluiddot marked this pull request as ready for review November 25, 2021 12:56
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@fluiddot fluiddot requested a review from hypest November 25, 2021 12:56
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 25, 2021

You can test the changes on this Pull Request by downloading the APKs:

@fluiddot fluiddot changed the base branch from develop to gutenberg/after_1.67.0 November 25, 2021 14:20
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Verified that both the Classic editor and gb-mobile work fine.

@@ -8,7 +8,7 @@ buildscript {
ext.wordPressUtilsVersion = '2.2.0'
ext.wordPressLoginVersion = '0.0.8'
ext.detektVersion = '1.15.0'
ext.gutenbergMobileVersion = 'v1.66.0'
ext.gutenbergMobileVersion = 'v1.68.0-alpha1'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might get a conflict after GB-mobile version 1.67.0 is merged into develop and we try merging the branch gutenberg/after_1.67.0. In that case, we might need to create a new tag v1.68.0-alpha2 to point to a later GB-mobile commit so it includes changes from 1.67.0 and the changes from wordpress-mobile/gutenberg-mobile#4290.

@fluiddot fluiddot added this to the 18.9 milestone Nov 25, 2021
@fluiddot fluiddot merged commit a340912 into gutenberg/after_1.67.0 Nov 25, 2021
@fluiddot fluiddot deleted the bump-aztec-v1.5.1 branch November 25, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants