Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditorFragment is missing the profiling stop calls #5860

Closed
mzorz opened this issue May 9, 2017 · 2 comments
Closed

EditorFragment is missing the profiling stop calls #5860

mzorz opened this issue May 9, 2017 · 2 comments

Comments

@mzorz
Copy link
Contributor

mzorz commented May 9, 2017

Only these calls are found in onCreate():

        ProfilingUtils.start("Visual Editor Startup");
        ProfilingUtils.split("EditorFragment.onCreate");

Should also have these in onDestroy:

                ProfilingUtils.dump();
                ProfilingUtils.stop();
Tested on [device], Android [version]
@aforcier
Copy link
Contributor

aforcier commented May 9, 2017

@mzorz we actually are calling them, once the WebView DOM has finished loading:

ProfilingUtils.split("EditorFragment.onDomLoaded completed");
ProfilingUtils.dump();
ProfilingUtils.stop();

@mzorz
Copy link
Contributor Author

mzorz commented May 9, 2017

gotcha @aforcier ! closing

@mzorz mzorz closed this as completed May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants