Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Updates - Main Batch - Plugins #17935

Closed
3 tasks done
ParaskP7 opened this issue Feb 9, 2023 · 2 comments
Closed
3 tasks done

Dependency Updates - Main Batch - Plugins #17935

ParaskP7 opened this issue Feb 9, 2023 · 2 comments

Comments

@ParaskP7
Copy link
Contributor

ParaskP7 commented Feb 9, 2023

Parent #17551


🚫 Blocked By (for Dagger):

  • Dependency Updates - Main Batch - AndroidX Compose/Kotlin #17563
    • Updating Dagger to 2.45 adds Kotlin 1.7.10 as a transitive dependency to the project. It is better to do the Kotlin update explicitly rather than implicitly.
    • Updating Navigation to 2.5.3 adds Kotlin 1.6.21 as a transitive dependency to the project. It is better to do the Kotlin update explicitly rather than implicitly.

FYI: Actually, on the Navigation update, the build even fails in this case, complaining on Compose Compiler incompatibility. Thus, unless Compose Compiler too is updated to point to 1.2.0-rc02, which is known to be compatible with Kotlin 1.6.21 (see Compose to Kotlin Compatibility Map), the build would not manage to succeed.

navigation-2.5.3

> Task :WordPress:compileJetpackWasabiDebugKotlin FAILED
e: This version (1.1.1) of the Compose Compiler requires Kotlin version 1.6.10 but you appear to
be using Kotlin version 1.6.21 which is not known to be compatible.  Please fix your configuration
(or `suppressKotlinVersionCompatibilityCheck` but don't say I didn't warn you!).

This issue is about updating all Main - Plugins related dependencies for the whole project.

This Main - Plugins batch contains only the following 2 dependencies:

@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

1 similar comment
@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant