Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QRCode Auth: Support WP.com Login #16481

Closed
31 tasks done
zwarm opened this issue May 5, 2022 · 1 comment
Closed
31 tasks done

QRCode Auth: Support WP.com Login #16481

zwarm opened this issue May 5, 2022 · 1 comment
Assignees
Milestone

Comments

@zwarm
Copy link
Contributor

zwarm commented May 5, 2022

This is the main project issue for supporting WordPress.com login by QR Code
Additional project information available here.

Implement Auth flow

Implement Scanning of QR Code into Auth Flow

Implement Deep Linking

  • QRCode Auth: Launch flow by deep link #16770
  • Add new folder for apps domain and hidden .well-known directory under it for assetlinks.json. This has to be deployed before any testing can be begin
    Note: Thank about strategy for maintaining state when a deep link occurs and the app was already open OR if it's needed at all.

Support in Jetpack Only

Bugs

Post Implementation - not required for launch
Remove viewModelScope.launch in postUiState - needs testing to ensure updates are not missed
Remove the 'invalid-data` check in FluxC, as the error comes back as a 401 and not a 400


Deployment Preparation


Future

  • Enable feature announcement in MC Tool
  • Remove feature flag
@zwarm zwarm added this to the Future milestone May 5, 2022
@zwarm zwarm self-assigned this May 5, 2022
@zwarm zwarm added the Login label May 5, 2022
@zwarm zwarm changed the title Support QR Code Login QRCode Auth: Support WP.com Login May 12, 2022
@zwarm
Copy link
Contributor Author

zwarm commented Jun 24, 2022

Feature is releasing with 20.2 and is guarded with a Firebase remote config flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant