Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow conversation by push notifications case to monitor/improvement #15471

Open
develric opened this issue Oct 15, 2021 · 0 comments
Open

Follow conversation by push notifications case to monitor/improvement #15471

develric opened this issue Oct 15, 2021 · 0 comments

Comments

@develric
Copy link
Contributor

This is related to an observed behaviour while testing this PR here

Slack internal ref: p1633941032482100-slack-C01CW1VMLAF

If the site that you want to follow a conversation on, has this below site global setting in the reader active

then the /sites/$site_id/posts/$post_id/subscribers/mine/update endpoint cannot set to true the receive_notifications field; thus in this condition currently an error is got back and the push notifications cannot be enabled.

This would require some changes in the endpoint but numbers for this scenario looking at the calypso_reader_comment_emails_toggle_on seems pretty low (if we are not wrong, like only 0.078% of MAUs are using that feature). We have setup a change in the endpoint (diff D68317) to bump a counter that we can review to define eventual action on the endpoint.

Props to @aerych for the time and advices looking into this 🙇 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant