Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported block bottom sheet is triggered when device is rotated #13052

Closed
guarani opened this issue Oct 2, 2020 · 3 comments · Fixed by WordPress/gutenberg#25873 or wordpress-mobile/gutenberg-mobile#2710
Assignees
Labels
Gutenberg Editing and display of Gutenberg blocks. [Type] Bug

Comments

@guarani
Copy link
Contributor

guarani commented Oct 2, 2020

Expected behavior

When a post that contains an unsupported block is open in the block editor, rotating the device shouldn't cause a bottom sheet to appear.

Actual behavior

When a post that contains an unsupported block is open in the block editor, rotating the device causes a bottom sheet to appear.

Steps to reproduce the behavior

  1. Open the block editor on a post that contains an unsupported block (e.g. Audio is a block that's not yet supported on mobile at time of writing)
  2. With the editor open, rotate the device and notice the bottom sheet appears
Tested on Samsung S10, Android 10, WPAndroid 15.7
@guarani
Copy link
Contributor Author

guarani commented Oct 2, 2020

The fix should be the same as what was done for the Reusable block component, see here.

@hypest
Copy link
Contributor

hypest commented Oct 5, 2020

Related and probably the same issue as wordpress-mobile/gutenberg-mobile#2680. Leaving both open until those get investigated. @marecar3 please check out both of these issues, thanks!

@marecar3
Copy link
Contributor

marecar3 commented Oct 5, 2020

Related and probably the same issue as wordpress-mobile/gutenberg-mobile#2680. Leaving both open until those get investigated. @marecar3 please check out both of these issues, thanks!

Thanks, @hypest, I will prioritize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Type] Bug
Projects
None yet
3 participants