-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MVC 구현하기 - 1단계] 춘식(안예장) 미션 제출합니다. #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SonarCloud Quality Gate failed. |
Sehwan-Jang
approved these changes
Sep 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요 춘식!
돌려봤을때 잘 동작하는것 확인했고, 코드도 정말 잘 구현해주셨어요! 오히려 리뷰하면서 제가 더 배운것 같네요 🙂
이번 단계는 이것으로 충분한 것 같아 바로 merge 하겠습니다.
몇몇 추가적인 코멘트들 남겼는데 이 부분들만 확인해주면 감사하겠습니다 ~~~
그럼 다음 단계도 화이팅이예요! 🔥🔥🔥
mvc/src/main/java/nextstep/mvc/controller/tobe/AnnotationHandlerMapping.java
Show resolved
Hide resolved
mvc/src/main/java/nextstep/mvc/controller/tobe/AnnotationHandlerMapping.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 아론!! 이번 미션 잘 부탁드립니다. 😄
http 미션도 어려웠다고 느꼈지만 이번 미션도 만만치 않게 어려웠던 거 같아요. 🥲
그래서 이번에는 2단계 리팩터링에 있는 클래스 다이어그램을 참고하면서 코드를 작성해봤습니다.
다이어그램을 참고하면서 진행하니 mvc 프레임워크의 흐름이 어느 정도 감이 잡혔던 것 같아요!!
또한 기존 인터페이스 기반 컨트롤러와 어노테이션 기반 컨트롤러가 같이 동작하도록 로그인, 회원가입 컨트롤러를 어노테이션 기반으로 작동하도록 변경했습니다!
코드를 작성하면서 의문이 들었던 부분은 JwpApplication을 실행할 때 css를 읽지 못하는 것 같아 난황을 겪었는데, Build를 gradle이 아닌 intelij로 변경하니 잘 되더라고요...? 🙃 이후로 다시 gradle로 바꿔보니 또 잘 되어서... 이유를 찾지 못한 채로 해결이 되었습니다ㅋㅋ큐ㅠㅠ
피드백은 모두 환영합니다!! 편하게 코멘트 남겨주세요 😉
(+) 도중에 mvc 패키지를 통째로 코드포맷팅을 돌렸더니 변한 파일 수가 의도치 않게 많아졌네요ㅠㅠ