[MVC 구현하기 - 3단계] 후디(조동현) 미션 제출합니다. #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 모든 컨트롤러를 애너테이션 기반으로 변경 - ModelAndView에 jspView() 정적 팩토리 메소드 추가 - 메인 페이지를 보여주는 MainController 추가 - ManualHandlerMapping 제거
|
kimchan123
suggested changes
Sep 28, 2022
| <a class="navbar-brand ps-3" href="/index.jsp">대시보드</a> | ||
| <!-- Sidebar Toggle--> | ||
| <button class="btn btn-link btn-sm order-1 order-lg-0 me-4 me-lg-0" id="sidebarToggle" href="#!"><i class="fas fa-bars"></i></button> | ||
| <head> |
There was a problem hiding this comment.
앗 ㅋㅋㅋ format on save 를 사용하고 있는데, HTML 수정하며 파일 전체가 포매팅 되었습니다! ㅋㅋ
| @Override | ||
| public void render(final Map<String, ?> model, final HttpServletRequest request, HttpServletResponse response) throws Exception { | ||
| public void render(final Map<String, ?> model, final HttpServletRequest request, HttpServletResponse response) |
There was a problem hiding this comment.
사실 이 부분은 큰 이유는 없고, 기존 레거시 인터페이스 View 코드를 그대로 따라갔습니다!
| @@ -16,6 +16,11 @@ public ModelAndView(final View view) { | |||
| this.model = new HashMap<>(); | |||
| } | |||
|
|
|||
| public static ModelAndView jspView(final String viewName) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요, 찬! 🙌
벌써 마지막 단계네요.
미션 중
마지막 단계도 잘 부탁드립니다!
지금 테스트 코드가 하나도 없는 상태인데, 리뷰 남겨주신 부분 개선하면서 추가해보도록 하겠습니다!