♻️ adjust recipe comment count on change #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
hyxrxn
changed the title
|
hyxrxn
reviewed
Aug 22, 2024
geoje
approved these changes
Aug 22, 2024
| assertThat(commentRepository.count()).isEqualTo(INITIAL_COMMENT_COUNT + 1); | ||
| assertAll( | ||
| () -> assertThat(commentRepository.count()).isEqualTo(INITIAL_COMMENT_COUNT + 1), | ||
| () -> assertThat(recipe.getCommentCount()).isEqualTo(before + 1) |
There was a problem hiding this comment.
commentService.createComment() 이후 (댓글 개수가 업데이트된) 레시피를 findbyId(2L) 로 새로 들고와서 비교해야할 것 같아요!
다음 스프린트 때 하시죠! :)
| assertThat(commentRepository.count()).isEqualTo(INITIAL_COMMENT_COUNT - 1); | ||
| assertAll( | ||
| () -> assertThat(commentRepository.count()).isEqualTo(INITIAL_COMMENT_COUNT - 1), | ||
| () -> assertThat(recipe.getCommentCount()).isEqualTo(before - 1) |
|
tackyu
approved these changes
Aug 22, 2024
|
|
||
| Recipe recipe = comment.getRecipe(); | ||
| recipe.decreaseCommentCount(); | ||
| recipeRepository.save(recipe); |
There was a problem hiding this comment.
@Transactional이 붙어있어서 더티 체킹이 될 것 같습니다.
save를 명시하지 않아도 괜찮을 것 같아요!
There was a problem hiding this comment.
그러네요!
빼고 테스트 해보니 잘 동작하네요... ㅎㅎ
지우겠습니다!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #338
코멘트 확인해주세요~