Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback to new two-row pipeline layout #4648

Closed
pat-s opened this issue Dec 30, 2024 · 6 comments
Closed

Feedback to new two-row pipeline layout #4648

pat-s opened this issue Dec 30, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@pat-s
Copy link
Contributor

pat-s commented Dec 30, 2024

Component

web-ui

Describe the bug

@qwerty287

image
  • Min-width of commit hash field should be larger
  • Sometimes the committer icon is missing (maybe use an anchored relative position for the start of the timing buttons so it doesn't matter if the icon is missing?)
  • Maybe the committer icon could also be moved as the first entry of the second line? This would avoid the layout shift in case it is missing (although it should always exist actually, not sure why it is missing in some runs in the new view)
@pat-s pat-s added the bug Something isn't working label Dec 30, 2024
@pat-s
Copy link
Contributor Author

pat-s commented Dec 30, 2024

Additional issues:

  • The status indicator was changed from w-3 to w-2 and now looks way to thin. Was this in purpose, @qwerty287?
  • Icons are not aligned with the text anymore
image

@qwerty287 Should we maybe revert and have a new clean PR?

@qwerty287
Copy link
Contributor

Should we maybe revert and have a new clean PR?

Maybe yes.

Tbh I just took the changes from @anbraten and added icons as requested in the original pr.

I mainly wanted to get the pipeline message and title/context (e.g. commit and pr title) difference what was done there...

@pat-s
Copy link
Contributor Author

pat-s commented Dec 30, 2024

All good, I also didn't test it in detail and I am partly guilty for merging :)

Let's revert and test it in more detail with PR images? Do you wanna revert or should I?

@qwerty287
Copy link
Contributor

You can do it, thanks

@xoxys
Copy link
Member

xoxys commented Dec 30, 2024

Maybe the committer icon could also be moved as the first entry of the second line? This would avoid the layout shift in case it is missing (although it should always exist actually, not sure why it is missing in some runs in the new view)

Its also possible to just reserve the required space (which is a good practice for images anyway)

@pat-s
Copy link
Contributor Author

pat-s commented Dec 31, 2024

reverted via #4649, new discussions should happen in a new PR then.

@pat-s pat-s closed this as completed Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants