Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent option "stop agent from taking new tasks" not working #1990

Closed
6543 opened this issue Jul 12, 2023 · 5 comments · Fixed by #3378
Closed

agent option "stop agent from taking new tasks" not working #1990

6543 opened this issue Jul 12, 2023 · 5 comments · Fixed by #3378
Labels
bug Something isn't working

Comments

@6543
Copy link
Member

6543 commented Jul 12, 2023

version: 8d62578 do not respect this option

@6543 6543 added the bug Something isn't working label Jul 12, 2023
@runephilosof-karnovgroup
Copy link
Contributor

runephilosof-karnovgroup commented Dec 20, 2023

If https://ci.woodpecker-ci.org/repos/3780/pipeline/10780/9 is using the autoscaler, then this issue might be causing the

Oh no, we got some errors!
Canceled

When an agent is shut down while processing a pipeline, this is sometimes the error message woodpecker shows.

@anbraten
Copy link
Member

Good catch.

@anbraten
Copy link
Member

anbraten commented Dec 21, 2023

I checked again using the latest main and with my agent in the debugger it seems to work and stops in

return nil, nil

@zc-devs
Copy link
Contributor

zc-devs commented Jan 10, 2024

2.1.1, Kubernetes - doesn't work.

@anbraten
Copy link
Member

The issue seems to be that the agent is long-polling and as soon as its inside of the queue.Poll() loop it wont recognize updates to NoSchedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants