-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename secrets to environment variables (use conceal flag) #1007
Comments
Would solve #362 as well |
But secrets are not really env variables, they are used quite differently |
They can be used by |
they are env vars ... but with spesific propertys like sanitazed in logs before leaving the agent ... and yes they can be used in settings where normal env-vars canot |
It would be a super hard and breaking job renaming it, but would only require one thing to maintain. But I am open for other suggestions. Would you just "copy" the UI / base logic from secrets? |
Env vars has one use case and secrets have other, only case where their use case overlaps is if they are specifically bound together in step definition. If we are talking about UI than yes they should have separate tab in settings and way more simple UI - just name and value that should be visible and editable not like secrets that you can just override with new value. |
Could this be used to get environment variables at repository level for several pipelines instead that to pipeline level? |
Seems not to be wanted |
WE currently have secrets and environment variables (can be set at server start). Instead I would suggest to rename secrets to environment variables and add an option to conceal environment variables which would be same to the current secrets.
This would allow us to have one way of managing those variables in ui, cli, pipeline parsing ...
The text was updated successfully, but these errors were encountered: