Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename secrets to environment variables (use conceal flag) #1007

Closed
anbraten opened this issue Jul 2, 2022 · 8 comments
Closed

Rename secrets to environment variables (use conceal flag) #1007

anbraten opened this issue Jul 2, 2022 · 8 comments

Comments

@anbraten
Copy link
Member

anbraten commented Jul 2, 2022

WE currently have secrets and environment variables (can be set at server start). Instead I would suggest to rename secrets to environment variables and add an option to conceal environment variables which would be same to the current secrets.

This would allow us to have one way of managing those variables in ui, cli, pipeline parsing ...

@anbraten
Copy link
Member Author

anbraten commented Sep 3, 2022

Would solve #362 as well

@lafriks
Copy link
Contributor

lafriks commented Sep 3, 2022

But secrets are not really env variables, they are used quite differently

@anbraten
Copy link
Member Author

anbraten commented Sep 3, 2022

They can be used by from_secret, are redacted from logs and what else?

@6543
Copy link
Member

6543 commented Sep 3, 2022

they are env vars ... but with spesific propertys like sanitazed in logs before leaving the agent

... and yes they can be used in settings where normal env-vars canot

@anbraten
Copy link
Member Author

anbraten commented Sep 3, 2022

It would be a super hard and breaking job renaming it, but would only require one thing to maintain. But I am open for other suggestions.

Would you just "copy" the UI / base logic from secrets?

@lafriks
Copy link
Contributor

lafriks commented Sep 3, 2022

Env vars has one use case and secrets have other, only case where their use case overlaps is if they are specifically bound together in step definition. If we are talking about UI than yes they should have separate tab in settings and way more simple UI - just name and value that should be visible and editable not like secrets that you can just override with new value.

@EchedelleLR
Copy link

Could this be used to get environment variables at repository level for several pipelines instead that to pipeline level?

@anbraten
Copy link
Member Author

Seems not to be wanted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants