[Navigation Feature] Remove code strategically

[psealock]

Instead of going through a deprecation process, we could remove the code functionality all at once and keep the classes like \Automattic\WooCommerce\Admin\Features\Navigation\Menu intact with dummy functions that return nothing, or maybe a notice. The default would be the current experience. Add a Tracks event in there and we’ll know for sure if anyone is actually using this feature.

[psealock]

Internal plugins with registration

These plugins have Navigation integration we need to remove. woocommerce/woocommerce-admin#5335

• Register WC Pay nav items in WC navigation Automattic/woocommerce-payments#1067 - Remove Navigation integration Automattic/woocommerce-payments#9228
• https://github.com/woocommerce/automatewoo/pull/836 - https://github.com/woocommerce/automatewoo/pull/1843
• https://github.com/woocommerce/automatewoo-referrals/pull/100 - https://github.com/woocommerce/automatewoo-referrals/pull/314
• Integration with new WC Navigation google-listings-and-ads#605 - Remove Woo Navigation integration google-listings-and-ads#2574
• https://github.com/woocommerce/woocommerce-subscriptions/pull/3868 - No sign of Navigation in current code base
• https://github.com/woocommerce/woocommerce-product-addons/pull/637 - https://github.com/woocommerce/woocommerce-product-addons/pull/1070
• Klarna - Remove Navigation feature integration krokedil/klarna-payments-for-woocommerce#396
• https://github.com/woocommerce/woocommerce-bookings/pull/3001 - https://github.com/woocommerce/woocommerce-bookings/pull/3846
• https://github.com/woocommerce/woocommerce-product-csv-import-suite/pull/186
• https://github.com/woocommerce/woocommerce-product-vendors/pull/618
• https://github.com/woocommerce/woocommerce-xero/pull/242
• https://github.com/woocommerce/woocommerce-box-office/pull/301
• Release 2.3.4 facebook/facebook-for-woocommerce#1837 - Removes WooCommerce navigation items facebook/facebook-for-woocommerce#2800

[tomalec]

Does the reference to "WooCommerce Navigation" in

woocommerce/docs/extension-development/working-with-woocommerce-admin-pages.md

Lines 62 to 64 in 8b35b07

	* `nav_args` (_optional_) - An array of parameters for registering items in WooCommerce Navigation. (see usage below)
	* `order` - Order number for presentation.
	* `parent` - Menu for item to fall under. For example: `woocommerce`, `woocommerce-settings` or `woocommerce-analytics`. Categories added by an extension are available as well.

means the removed navigation, or the regular one?

Also, should we keep the code like this https://github.com/woocommerce/woocommerce/blob/8b35b0785c761bda0b90188ade462c83af5b3643/plugins/woocommerce/src/Internal/Admin/WcPayWelcomePage.php#L122:L138 in place for some longer support?

[psealock]

means the removed navigation, or the regular one?

Thanks @tomalec, yes that is the one that was removed. Thanks for surfacing.

Also, should we keep the code like this

Good find as well, this can be safely removed. I can't think of a reason why "Payments" would need to be added once again if the option is set to yes as the entire UI has been removed.