Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add filters for allowed_country_currency_matrix and country_card_matrix (495) #437

Closed
davoraltman opened this issue Jan 10, 2022 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@davoraltman
Copy link

davoraltman commented Jan 10, 2022

Hi folks,

We're trying to enable ACDC for stores in Hong Kong. To enable this option, we first need to modify the plugin's file (attached is the guide we received from PayPal, referring to SG instead of HK but the drill is the same).

Enabling_ACDC_in_WooCommerce.pdf

We modified woocommerce-paypal-payments/modules/ppcp-api-client/services.php (not DccApplies.php from the guide as it didn't work) but the problem with this approach is that we would need to modify the plugin's core file each time the plugin is updated. As a potential solution, we are suggesting that two filters be added to the plugin - allowed_country_currency_matrix and country_card_matrix so that we can modify the array outside of the core plugin. Thank you!

P.S. If there's another way for us to work around this issue, please do let me know. Thanks!

@InpsydeNiklas InpsydeNiklas added the enhancement New feature or request label Jan 10, 2022
@InpsydeNiklas InpsydeNiklas changed the title [Enhancement] Add filters for allowed_country_currency_matrix and country_card_matrix [Enhancement] Add filters for allowed_country_currency_matrix and country_card_matrix (495) Jan 10, 2022
@InpsydeNiklas
Copy link
Member

The only alternative to modifying the code would be to set the WooCommerce store location in the General settings tab to a supported country/currency:
https://developer.paypal.com/docs/checkout/advanced/currency-availability-advanced-cards/

@Dinamiko
Copy link
Contributor

Fixed in #485.

@Dinamiko
Copy link
Contributor

Filter documentation added to repo wiki: https://github.com/woocommerce/woocommerce-paypal-payments/wiki/Actions-and-Filters#add-advanced-credit-and-debit-card-acdc-countries

@Dinamiko Dinamiko mentioned this issue Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants