From 583d587811fe369fd9062969f7954db5671961a9 Mon Sep 17 00:00:00 2001 From: Alex P Date: Tue, 14 Dec 2021 18:39:33 +0200 Subject: [PATCH 1/2] Do not remove html for plugin settings text inputs --- modules/ppcp-wc-gateway/src/Settings/SettingsListener.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ppcp-wc-gateway/src/Settings/SettingsListener.php b/modules/ppcp-wc-gateway/src/Settings/SettingsListener.php index 3155c79df..de8c37de7 100644 --- a/modules/ppcp-wc-gateway/src/Settings/SettingsListener.php +++ b/modules/ppcp-wc-gateway/src/Settings/SettingsListener.php @@ -373,7 +373,7 @@ private function retrieve_settings_from_raw_data( array $raw_data ): array { case 'number': case 'ppcp-text-input': case 'ppcp-password': - $settings[ $key ] = isset( $raw_data[ $key ] ) ? sanitize_text_field( $raw_data[ $key ] ) : ''; + $settings[ $key ] = isset( $raw_data[ $key ] ) ? wp_kses_post( $raw_data[ $key ] ) : ''; break; case 'password': if ( empty( $raw_data[ $key ] ) ) { From 151484165dada8cbeeac0058a692ebbbf3b512c8 Mon Sep 17 00:00:00 2001 From: Alex P Date: Tue, 14 Dec 2021 18:41:14 +0200 Subject: [PATCH 2/2] Do not sanitize passwords --- modules/ppcp-wc-gateway/src/Settings/SettingsListener.php | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/modules/ppcp-wc-gateway/src/Settings/SettingsListener.php b/modules/ppcp-wc-gateway/src/Settings/SettingsListener.php index de8c37de7..cbbbbae5e 100644 --- a/modules/ppcp-wc-gateway/src/Settings/SettingsListener.php +++ b/modules/ppcp-wc-gateway/src/Settings/SettingsListener.php @@ -372,14 +372,11 @@ private function retrieve_settings_from_raw_data( array $raw_data ): array { case 'text': case 'number': case 'ppcp-text-input': - case 'ppcp-password': $settings[ $key ] = isset( $raw_data[ $key ] ) ? wp_kses_post( $raw_data[ $key ] ) : ''; break; + case 'ppcp-password': case 'password': - if ( empty( $raw_data[ $key ] ) ) { - break; - } - $settings[ $key ] = sanitize_text_field( $raw_data[ $key ] ); + $settings[ $key ] = $raw_data[ $key ] ?? ''; break; case 'ppcp-multiselect': $values = isset( $raw_data[ $key ] ) ? (array) $raw_data[ $key ] : array();