This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
skip-changelog
PRs that you don't want to appear in the changelog.
type: task
The issue is an internally driven task (e.g. from another A8c team).
labels
Sep 7, 2023
woocommercebot
requested review from
a team and
sunyatasattva
and removed request for
a team
September 7, 2023 09:42
The release ZIP for this PR is accessible via:
TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. Script Dependencies ReportThe
This comment was automatically generated by the |
Closed in favor of #10866 |
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
skip-changelog
PRs that you don't want to appear in the changelog.
type: task
The issue is an internally driven task (e.g. from another A8c team).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #
Why
This PR fixes some lint errors. I'm not sure which is the root of this issue, but with #10788 we recreate the package-lock.json from scratch, and maybe the default configuration of ESLint is changed. Given that it is not a huge issue, I don't think that it makes sense to investigate further.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]
label or a[skip-changelog]
label.Conditional:
[skip-changelog]
label is not present).Changelog