Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Investigate why redirectURL could be non-truthy and wheth... #4224

Closed
github-actions bot opened this issue May 18, 2021 · 3 comments · Fixed by #5560
Closed

Investigate why redirectURL could be non-truthy and wheth... #4224

github-actions bot opened this issue May 18, 2021 · 3 comments · Fixed by #5560
Assignees
@mikejolley
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@github-actions
Copy link
Contributor

Investigate why redirectURL could be non-truthy and whether this would cause a bug if multiple gateways were used for payment e.g. 1st set the redirect URL but failed, and then the 2nd did not provide a redirect URL and succeeded.

https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/42b89b49820d1d92d98024face0d723c782f6030/assets/js/base/context/providers/cart-checkout/checkout-state/reducer.ts#L69-L80

🚀 This issue was generated by the automations bot based on a todo comment in 42b89b4 when #4200 was merged. cc @mikejolley
@nerrad nerrad added category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. type: technical debt This issue/PR represents/solves the technical debt of the project. labels May 18, 2021
@github-actions
Copy link
Contributor Author

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jul 18, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Jul 18, 2021
@github-actions
Copy link
Contributor Author

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Sep 17, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Oct 1, 2021
@nerrad nerrad reopened this Oct 1, 2021
@github-actions
Copy link
Contributor Author

github-actions bot commented Dec 1, 2021

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 1, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 1, 2021
@mikejolley mikejolley self-assigned this Jan 13, 2022
@mikejolley mikejolley mentioned this issue Jan 13, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mikejolley mikejolley

Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent Redirect URL leaking between payment gateways woocommerce/woocommerce-blocks
2 participants
@mikejolley @nerrad