Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Add icons to Product Link, Product Category Link and Product Tag Link block variations #4147

Closed
Aljullu opened this issue Apr 28, 2021 · 10 comments
Labels
focus: FSE Work related to prepare WooCommerce for FSE. needs: design The issue requires design input/work from a designer. status: stale Stale issues and PRs have had no updates for 60 days. type: enhancement The issue is a request for an enhancement.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Apr 28, 2021

In woocommerce/woocommerce#29772 we updated the Product custom post type and the Product Category and Product Tag taxonomies so they display the correct labels and show up as suggestions when adding their block variations. This issue is about adding icons to them. Currently, there is not a direct API for doing that and instead a JS filter must be used (code example: WordPress/gutenberg#31226 (comment)).

This is how they currently look with the default icons:

Screenshot showing the same icon for all three product variations

Even though these block variations don't directly exist in this repo (they are automatically generated by Gutenberg based on the CPT and taxonomies of WC core), I think the best repo to host the JS filter is this one.

@vivialice will be working on generating those icons.

@Aljullu Aljullu added type: enhancement The issue is a request for an enhancement. needs: design The issue requires design input/work from a designer. focus: FSE Work related to prepare WooCommerce for FSE. labels Apr 28, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jun 28, 2021
@Aljullu Aljullu removed the status: stale Stale issues and PRs have had no updates for 60 days. label Jul 1, 2021
@Aljullu
Copy link
Contributor Author

Aljullu commented Jul 1, 2021

Given that there is some discussion on what will be the final UI to insert different block variations inside the Navigation block (WordPress/gutenberg#31584), I would argue this is a low priority issue. We can prioritize it once the Navigation block is closer to get integrated into WordPress core.

@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Aug 31, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Sep 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2021

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Nov 3, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Nov 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2022

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jan 3, 2022
@Aljullu Aljullu removed the status: stale Stale issues and PRs have had no updates for 60 days. label Jan 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2022

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Mar 5, 2022
@Aljullu Aljullu removed the status: stale Stale issues and PRs have had no updates for 60 days. label Mar 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label May 6, 2022
@Aljullu Aljullu removed the status: stale Stale issues and PRs have had no updates for 60 days. label May 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jul 7, 2022
@Aljullu Aljullu removed the status: stale Stale issues and PRs have had no updates for 60 days. label Jul 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Sep 6, 2022
@Aljullu
Copy link
Contributor Author

Aljullu commented Feb 24, 2023

If I'm not wrong, these blocks are no longer visible from the UI, so closing this issue.

@Aljullu Aljullu closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: FSE Work related to prepare WooCommerce for FSE. needs: design The issue requires design input/work from a designer. status: stale Stale issues and PRs have had no updates for 60 days. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants