Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Convert the button in the Featured Product block into a full-featured Button block #368

Closed
jameskoster opened this issue Jan 29, 2019 · 1 comment
Labels
type: enhancement The issue is a request for an enhancement.
Milestone

Comments

@jameskoster
Copy link
Member

Folks expect the edit-ability of this button to match the core button block.

Ito design it should mimic other nested blocks, e.g. the Media and Text block:

button

Clicking on the button switches focus to that block and reveals the corresponding settings, with two exceptions;

  • In the Featured Product block it should not be possible to edit the button destination url.
  • It should also not be possible to adjust the button alignment (this is governed by the parent block justification setting).

All other settings should be included.

After making this change we can remove the b i s options on the Featured Product block toolbar as these are currently only applied to the button anyway. Folks found this confusing as they weren't sure whether it would be applied to the product title / price / description as well. It should still be possible to apply b i s to the button, but this should be handled through the Button block toolbar.

@jameskoster jameskoster added the type: enhancement The issue is a request for an enhancement. label Jan 29, 2019
@ryelle ryelle self-assigned this Jan 29, 2019
@ryelle ryelle added the Blocks label Jan 29, 2019
@ryelle ryelle removed their assignment Jan 29, 2019
@ryelle ryelle modified the milestones: 2.0 + Core Merge, 1.4.0 Sprint Feb 12, 2019
@ryelle
Copy link
Member

ryelle commented Feb 12, 2019

Done in #398

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants