Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Remove payment status setters from payment method extension interface. #2110

Closed
nerrad opened this issue Apr 3, 2020 · 0 comments · Fixed by #2116
Closed

Remove payment status setters from payment method extension interface. #2110

nerrad opened this issue Apr 3, 2020 · 0 comments · Fixed by #2116
Assignees
@nerrad
Labels
category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. type: refactor The issue/PR is related to refactoring.
Milestone
2.6.0

Comments

@nerrad
Copy link
Contributor

nerrad commented Apr 3, 2020

#2108 added new event emitters for payment status changes that are now controlled by checkout. So payment methods should not need to change the payment status (instead return response from observers registered to events affect whether payment status changes.

This issue is for removing the payment status setter from the payment method interface.
@nerrad nerrad self-assigned this Apr 3, 2020
@nerrad nerrad added category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. type: refactor The issue/PR is related to refactoring. labels Apr 3, 2020
@nerrad nerrad added this to the Future Release milestone Apr 3, 2020
This was referenced Apr 3, 2020
Closed
Merged
Merged
@nerrad nerrad modified the milestones: Future Release, 2.6.0 Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nerrad nerrad

Labels
category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. type: refactor The issue/PR is related to refactoring.
Projects
None yet
Milestone
2.6.0
Development

Successfully merging a pull request may close this issue.

Refactor payment method interface to remove payment status dispatcher woocommerce/woocommerce-blocks
1 participant
@nerrad