Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Add Unit Tests for New Hooks #1475

Closed
4 of 17 tasks
nerrad opened this issue Jan 3, 2020 · 5 comments
Closed
4 of 17 tasks

Add Unit Tests for New Hooks #1475

nerrad opened this issue Jan 3, 2020 · 5 comments
Labels
needs: tests The issue/PR needs tests before it can move forward. status: stale Stale issues and PRs have had no updates for 60 days. type: enhancement The issue is a request for an enhancement.

Comments

@nerrad
Copy link
Contributor

nerrad commented Jan 3, 2020

In #1349 a number of new hooks were introduced. This issue is to ensure we get unit tests added for these new hooks. Also should add unit tests for the payment method registration api.

Add tests for:

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label type: feature request to this issue, with a confidence of 0.89. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@nerrad nerrad added type: enhancement The issue is a request for an enhancement. and removed type: feature request labels Jan 24, 2020
@nerrad nerrad added this to the Future Release milestone Jan 27, 2020
@Aljullu Aljullu self-assigned this Mar 23, 2020
@Aljullu Aljullu added the needs: tests The issue/PR needs tests before it can move forward. label Mar 24, 2020
@Aljullu
Copy link
Contributor

Aljullu commented Mar 24, 2020

I updated the list above with all the hooks that are currently missing tests.

In #2013 I added tests to some of them. I will unassign this issue from me since I will be working on something else for now.

@nerrad
Copy link
Contributor Author

nerrad commented Mar 24, 2020

Thanks for getting the ball rolling Albert!

@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

######Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 17, 2020
@nerrad
Copy link
Contributor Author

nerrad commented Dec 17, 2020

I'm going to close this. Expanding our test coverage is an ongoing thing that we need to be watching for as we work on code.

@nerrad nerrad closed this as completed Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: tests The issue/PR needs tests before it can move forward. status: stale Stale issues and PRs have had no updates for 60 days. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants