Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Create Payment Methods for Stripe #1471

Closed
nerrad opened this issue Jan 3, 2020 · 1 comment · Fixed by #1983
Closed

Create Payment Methods for Stripe #1471

nerrad opened this issue Jan 3, 2020 · 1 comment · Fixed by #1983
Assignees
Labels
type: enhancement The issue is a request for an enhancement.
Milestone

Comments

@nerrad
Copy link
Contributor

nerrad commented Jan 3, 2020

Using the api introduced in #1349, this pull will create the ExpressPaymentMethod and PaymentMethod integrations for Stripe. Some notes:

  • should use as much of the existing stripe extension logic as possible (so will need to detect if the extension is installed).
  • should be created with a goal of moving this logic to the actual payment method extensions themselves (possibly before release). We may need to talk more about this.
  • Will need to expose icons (on a yet to be built api) for the cart payment icons. (see Cart: Create api for payment methods to expose card icons. #1472)

Here's an updated mockup provided by @LevinMedia that shows a few changes:

Image 2020-03-25 at 11 52 31 AM

  • label for stripe tab is Credit/Debit Card
  • Credit card icons get moved to below save payment information checkbox.
  • Saved payment methods are moved outside of the PaymentMethod component and are a part of the payment step (saved payment methods are provided by checkout).
  • Payment Method component only gets displayed if there are no saved payment methods or "Use a new payment method" is selected.
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label type: feature request to this issue, with a confidence of 0.97. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.