Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Checkout Block: Step One - Contact Information #1345

Closed
nerrad opened this issue Dec 7, 2019 · 6 comments
Closed

Checkout Block: Step One - Contact Information #1345

nerrad opened this issue Dec 7, 2019 · 6 comments
Assignees

Comments

@nerrad
Copy link
Contributor

nerrad commented Dec 7, 2019

As per the exploration done by @Aljullu in #1208 this issue is concerned with the Contact Step in the form area of the checkout template:

contact information step

/base/components/checkout/contact-information

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label type: feature request to this issue, with a confidence of 0.66. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@nerrad nerrad changed the title Checkout Block: Step One - Contact Information Checkout Block: Step One - Contact Information Components Dec 7, 2019
@nerrad nerrad changed the title Checkout Block: Step One - Contact Information Components Checkout Block: Step One - Contact Information Dec 7, 2019
@senadir
Copy link
Member

senadir commented Dec 13, 2019

I'm just noticing this & #1346, I guess #1348 should solve them all?

@nerrad
Copy link
Contributor Author

nerrad commented Dec 13, 2019

Ya you can close this issue with #1348. However I think #1346 still has work to do for when there are no shipping options available.

@senadir
Copy link
Member

senadir commented Dec 13, 2019

Yeah, for now I just supplied a shippingMethods props and worked around it and I'm building the placeholder until we have datastores in place

@senadir senadir self-assigned this Dec 13, 2019
@nerrad
Copy link
Contributor Author

nerrad commented Dec 17, 2019

@senadir is this issue considered closed from the work done in #1351?

@senadir
Copy link
Member

senadir commented Dec 17, 2019

yes, some itiration should still be done to those components but we can close this

@senadir senadir closed this as completed Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants