Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Checkout Block: Express Checkout Section - Edit Context #1302

Closed
nerrad opened this issue Dec 2, 2019 · 2 comments
Closed

Checkout Block: Express Checkout Section - Edit Context #1302

nerrad opened this issue Dec 2, 2019 · 2 comments
Assignees
Labels
focus: components Work that introduces new or updates existing components.

Comments

@nerrad
Copy link
Contributor

nerrad commented Dec 2, 2019

Note: when working on this issue, please give due consideration to:

  • Are there components that can be pulled from @wordpress/components (i.e. <Card>)?
  • Are there components that can be pulled from @woocommerce/components?
  • Are there components/logic that can be pulled from @automattic/components or @automattic/composite-checkout

We want to avoid duplication of work/logic already done elsewhere as much as possible.

As per the exploration done by @Aljullu in #1208 this issue is concerned with the Express checkout area of the checkout.

In context of entire view:

checkout

Express Checkout section:

express-checkout

Suggested Components

  • ExpressCheckout (/base/components/checkout/express-checkout)
  • ExpressCheckoutButton (/base/components/checkout/express-checkout-button)

Other

Also let's use this issue to add the "Or continue below" separator (base/components/separator)

continue-below

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label type: feature request to this issue, with a confidence of 0.66. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@nerrad nerrad self-assigned this Dec 6, 2019
@nerrad nerrad added the focus: components Work that introduces new or updates existing components. label Dec 7, 2019
@nerrad
Copy link
Contributor Author

nerrad commented Jan 7, 2020

This is completed with the merge of #1349 (remaining work covered by other issues).

@nerrad nerrad closed this as completed Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: components Work that introduces new or updates existing components.
Projects
None yet
Development

No branches or pull requests

1 participant