Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Replace deprecated button props isPrimary, isSecondary, isTertiary and isLink #11855

Closed
nielslange opened this issue Nov 21, 2023 · 2 comments · Fixed by #11933
Closed

Replace deprecated button props isPrimary, isSecondary, isTertiary and isLink #11855

nielslange opened this issue Nov 21, 2023 · 2 comments · Fixed by #11933
Assignees
Labels
priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. team: Kirigami & Origami type: cooldown Things that are queued for a cooldown period (assists with planning). type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@nielslange
Copy link
Member

With Gutenberg 14.2.0, the button propsisPrimary, isSecondary, isTertiary and isLink have been deprecated in favour of variant. See https://github.com/WordPress/gutenberg/blob/trunk/packages/components/CHANGELOG.md#1420-2021-07-21 and WordPress/gutenberg#31713.

Currently, we're still using all four deprecated button props:

  • isPrimary → should be replaced with variant="primary"
  • isSecondary → should be replaced with variant="secondary"
  • isTertiary → should be replaced with variant="tertiary"
  • isLink → should be replaced with variant="link"

Reference:

@nielslange nielslange added type: cooldown Things that are queued for a cooldown period (assists with planning). type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. type: technical debt This issue/PR represents/solves the technical debt of the project. labels Nov 21, 2023
@tarunvijwani tarunvijwani added the priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. label Nov 21, 2023
@arsanyjoseph
Copy link
Contributor

@nielslange I would like to work on this.
if you don't mind, please assign me.
Thanks

@nielslange
Copy link
Member Author

Hello @arsanyjoseph 👋

Thanks for volunteering to work on this issue. I just assigned it to you. For any clarifications, please feel free to reach out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. team: Kirigami & Origami type: cooldown Things that are queued for a cooldown period (assists with planning). type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
4 participants